Jump to content

Welcome to the new Traders Laboratory! Please bear with us as we finish the migration over the next few days. If you find any issues, want to leave feedback, get in touch with us, or offer suggestions please post to the Support forum here.

  • Welcome Guests

    Welcome. You are currently viewing the forum as a guest which does not give you access to all the great features at Traders Laboratory such as interacting with members, access to all forums, downloading attachments, and eligibility to win free giveaways. Registration is fast, simple and absolutely free. Create a FREE Traders Laboratory account here.

clbradley

Triangle Pattern Indicator Code Not Working

Recommended Posts

Hey. Have tried this older Triangle Pattern Code I found on the net for Tradestation, but apparently the code has changed, and it doesn't recognize the word triangle. Can anyone help? Thanks.

 

Here's the code, indicator's at the bottom, function at the top:

 

Triangle Pattern Indicator by Walt Downs

 

Origin: omega-list

Written by: Walt Downs

Date found: 1 dec 97

 

Indicator calculates triangles based on SwingHighs and lows of a 10 day range, and with a swing strength of "1". Larger

triangles can be calculated by increasing the strength and/or HighestBar/LowestBar range settings. The indicator plots

a simple "spike" graph, alerting the trader to the presence of a triangle. The trader can then apply logical trendlines to establish break-out points.

 

 

 

Type : Function, Name : Triangle Pattern Indicator

 

input:

OccurH1(numericsimple),OccurH2(numericsimple),OccurL1(numericsimple),

OccurL2(numericsimple),PriceH1(numericseries),PriceH2(numericseries),

PriceL1(numericseries),PriceL2(numericseries),StrenH(numericsimple),

StrenL(numericsimple),Len(numericsimple);

 

value1 = SwingHighBar(OccurH1,PriceH1,StrenH,Len);

value2 = SwingHighBar(OccurH2,PriceH2,StrenH,Len);

value3 = SwingLowBar(OccurL1,PriceL1,StrenL,Len);

value4 = SwingLowBar(OccurL2,PriceL2,StrenL,Len);

 

 

Condition1 = high of value2 bars ago > high of value1 bars ago;

Condition2 = low of value4 bars ago < low of value3 bars ago;

Condition3 = HighestBar(H,Len) = value2;

Condition4 = LowestBar(low,Len) = value4;

 

if

Condition1 and

Condition2 and

Condition3 and

Condition4

then Triangle = true

else Triangle = false;

 

 

 

 

 

Type : Indicator, Name : Triangle Pattern Indicator

 

input:

OccurH1(1),

OccurH2(2),

OccurL1(1),

OccurL2(2),

PriceH1(high),

PriceH2(high),

PriceL1(low),

PriceL2(low),

StrenH(1),

StrenL(1),

Len(10);

 

if

Triangle(OccurH1,OccurH2,OccurL1,OccurL2,PriceH1,

PriceH2,PriceL1,PriceL2,StrenH,StrenL,Len)

= true then plot1(10,"TriFinder")

else plot1(0,"TriFinder");

 

if

Triangle(OccurH1,OccurH2,OccurL1,OccurL2,PriceH1,PriceH2,

PriceL1,PriceL2,StrenH,StrenL,Len)

= true then Alert = true;

Share this post


Link to post
Share on other sites

I made the function Triangle as you noted, yet keep getting an error message that says "Arithmetic (numeric) expression expected here". It is alluding to the word "true" in the 2nd to last sentence, "then Triangle = true"

 

It will probably say the same thing for false once I fix true. What Arithmetic (numeric) expression should I use instead of true or false near the end of the function code?

Thanks.

 

Curtis

Share this post


Link to post
Share on other sites

I am trying to verify, and if there were no errors (this box says Grammar error), then it says verification successful and no problem. This grammar error it blacks out the word "true" (and I tried replacing it with "TrueFalse" and get the same Grammor error message) and within the Grammar error box it says "Arithmetic (numeric) expression expected here. Underneath that you click a little box that says OK, and it just leaves you to figure out what to put instead of the blacked over true or TrueFalse, because they don't work. Have the 2nd to most recent platform, see one just came out within the last week, have Tradestation 8.4 (Build 1693). Try it if you're not sure, but it won't verify for me with true or TrueFalse there near the end after "then Triangle =". It seems to want a # I'm guessing by the "Arithmetic (numeric) expression expected here" message. Thanks for any help.

 

Curtis

Share this post


Link to post
Share on other sites
I am trying to verify, and if there were no errors (this box says Grammar error), then it says verification successful and no problem. This grammar error it blacks out the word "true" (and I tried replacing it with "TrueFalse" and get the same Grammor error message) and within the Grammar error box it says "Arithmetic (numeric) expression expected here. Underneath that you click a little box that says OK, and it just leaves you to figure out what to put instead of the blacked over true or TrueFalse, because they don't work. Have the 2nd to most recent platform, see one just came out within the last week, have Tradestation 8.4 (Build 1693). Try it if you're not sure, but it won't verify for me with true or TrueFalse there near the end after "then Triangle =". It seems to want a # I'm guessing by the "Arithmetic (numeric) expression expected here" message. Thanks for any help.

 

Curtis

 

To be honest, I have no idea what you are saying above, but attached is the code for the function and the indicator in .els format. I only have Tradestation 2000 but I guess TS 8.4 would be able to import .els files. Both compiled and I was able to apply the indicator to a chart, but I did not check if it shows anything meaningful.

TRIANGLE.zip

Share this post


Link to post
Share on other sites

Thanks for trying to help Tams and sevensa, but uploaded the function and indicator from your ELS, tried to use it, and get a TS box that says "study not verified". So I opened the indicator and tried to verify, and it said "Error found in function", and blacked over the word Triangle. So they must have changed what Easy Language (that's a laugh) is recognized between your platform and the more recent ones. Thanks again.

 

Curtis

Share this post


Link to post
Share on other sites
Thanks for trying to help Tams and sevensa, but uploaded the function and indicator from your ELS, tried to use it, and get a TS box that says "study not verified". So I opened the indicator and tried to verify, and it said "Error found in function", and blacked over the word Triangle. So they must have changed what Easy Language (that's a laugh) is recognized between your platform and the more recent ones. Thanks again.

Curtis

 

1. every time you import, you must verify the codes before they can be used.

(another term for verify is "compile").

 

2. please first delete the "Triangle" function from your computer. The function needs to be set to TrueFalse. This will be done automatically when you import from ELS.

 

I have imported the above codes to MultiCharts and they compile with no problem.

Share this post


Link to post
Share on other sites

Sorry, Multicharts is very different from TS. Things and words that worked on a previous platform at TS won't work on a newer one, and have found that it won't recognnize several words frequently in older codes, and this one is from 1997. I did delete everything, and someone at TS told me to change the function from numeric while starting a new one, to boolean (true/false), and that function verified, and so did the indicator, and tried to use it on a chart, nothing showed up, but received a pop up TS events log that stated "tried to reference future data". May just have to do without this indicator, it just doesn't seem compatible for the latest platform of TS with this code. Thanks for your help.

 

Curtis

Share this post


Link to post
Share on other sites

I would persevere. The fact it works for Tams & Svensa suggests it is not a problem with the indicator.

 

When it comes to easy language MC & TS are not very different. Quite the reverse.

 

Edit: There does appear to be bug in the codes logic in so far as it references a bar in the future.

Edited by BlowFish

Share this post


Link to post
Share on other sites
Sorry, Multicharts is very different from TS. Things and words that worked on a previous platform at TS won't work on a newer one, and have found that it won't recognnize several words frequently in older codes, and this one is from 1997. I did delete everything, and someone at TS told me to change the function from numeric while starting a new one, to boolean (true/false), and that function verified, and so did the indicator, and tried to use it on a chart, nothing showed up, but received a pop up TS events log that stated "tried to reference future data". May just have to do without this indicator, it just doesn't seem compatible for the latest platform of TS with this code. Thanks for your help.

Curtis

 

The indicator and function VERIFIED !

That's the important thing; that means the code was good.

You have achieved a mile stone.

Congratulations,

Give yourself a pad on the back.

 

The error message "tried to reference future data" means the indicator is a very sensitive one: you need to adjust the variables to meet the chart's volatility.

 

Go into Format Study and change the "Len" to 30.

You can use this as a starting point to fine tune the indicator.

Share this post


Link to post
Share on other sites

Well, everybody is right on this one, and welcome to the forum, Curtis.

 

Every version of MC and TS is slightly different in error checking and the recent versions of TS tend to stop indicators from functioning if they attempt to reference non existing values, such as the future data that you mentioned.

 

In order to correct this, please replace the 4 lines (value1...value4) with the following code fragment in the Triangle function:

 

if SwingHighBar(OccurH1,PriceH1,StrenH,Len) <> -1 then
value1 = SwingHighBar(OccurH1,PriceH1,StrenH,Len);
if SwingHighBar(OccurH2,PriceH2,StrenH,Len) <> -1 then
value2 = SwingHighBar(OccurH2,PriceH2,StrenH,Len);
if SwingLowBar(OccurL1,PriceL1,StrenL,Len) <> -1 then
value3 = SwingLowBar(OccurL1,PriceL1,StrenL,Len);
if SwingLowBar(OccurL2,PriceL2,StrenL,Len) <> -1 then
value4 = SwingLowBar(OccurL2,PriceL2,StrenL,Len);

 

Alternatively, use this revised Triangle function:

[LegacyColorValue = true]; 

input:
OccurH1(numericsimple),OccurH2(numericsimple),OccurL1(numericsimple),
OccurL2(numericsimple),PriceH1(numericseries),PriceH2(numericseries),
PriceL1(numericseries),PriceL2(numericseries),StrenH(numericsimple),
StrenL(numericsimple),Len (numericsimple);

if SwingHighBar(OccurH1,PriceH1,StrenH,Len) <> -1 then
value1 = SwingHighBar(OccurH1,PriceH1,StrenH,Len);
if SwingHighBar(OccurH2,PriceH2,StrenH,Len) <> -1 then
value2 = SwingHighBar(OccurH2,PriceH2,StrenH,Len);
if SwingLowBar(OccurL1,PriceL1,StrenL,Len) <> -1 then
value3 = SwingLowBar(OccurL1,PriceL1,StrenL,Len);
if SwingLowBar(OccurL2,PriceL2,StrenL,Len) <> -1 then
value4 = SwingLowBar(OccurL2,PriceL2,StrenL,Len);


Condition1 = high of value2 bars ago > high of value1 bars ago;
Condition2 = low of value4 bars ago < low of value3 bars ago;
Condition3 = HighestBar(H,Len) = value2;
Condition4 = LowestBar(low,Len) = value4;

if 
Condition1 and
Condition2 and
Condition3 and
Condition4
then Triangle = true
else Triangle = false;

Share this post


Link to post
Share on other sites
Tams, did you get a plot error in MC, trying to reference future data -1 error? I did, so just wondering if you knew how to solve the error. I tried adding more space on it, but still error?

Thanks

you can see my post above.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Topics

  • Posts

    • How's about other crypto exchanges? Are all they banned in your country or only Binance?
    • Be careful who you blame.   I can tell you one thing for sure.   Effective traders don’t blame others when things start to go wrong.   You can hang onto your tendency to play the victim, or the martyr… but if you want to achieve in trading, you have to be prepared to take responsibility.   People assign reasons to outcomes, whether based on internal or external factors.   When traders face losses, it's common for them to blame bad luck, poor advice, or other external factors, rather than reflecting on their own personal attributes like arrogance, fear, or greed.   This is a challenging lesson to grasp in your trading journey, but one that holds immense value.   This is called attribution theory. Taking responsibility for your actions is the key to improving your trading skills. Pause and ask yourself - What role did I play in my financial decisions?   After all, you were the one who listened to that source, and decided to act on that trade based on the rumour. Attributing results solely to external circumstances is what is known as having an ‘external locus of control’.   It's a concept coined by psychologist Julian Rotter in 1954. A trader with an external locus of control might say, "I made a profit because the markets are currently favourable."   Instead, strive to develop an "internal locus of control" and take ownership of your actions.   Assume that all trading results are within your realm of responsibility and actively seek ways to improve your own behaviour.   This is the fastest route to enhancing your trading abilities. A trader with an internal locus of control might proudly state, "My equity curve is rising because I am a disciplined trader who faithfully follows my trading plan." Author: Louise Bedford Source: https://www.tradinggame.com.au/
    • SELF IMPROVEMENT.   The whole self-help industry began when Dale Carnegie published How to Win Friends and Influence People in 1936. Then came other classics like Think And Grow Rich by Napoleon Hill, Awaken the Giant Within by Tony Robbins toward the end of the century.   Today, teaching people how to improve themselves is a business. A pure ruthless business where some people sell utter bullshit.   There are broke Instagrammers and YouTubers with literally no solid background teaching men how to be attractive to women, how to begin a start-up, how to become successful — most of these guys speaking nothing more than hollow motivational words and cliche stuff. They waste your time. Some of these people who present themselves as hugely successful also give talks and write books.   There are so many books on financial advice, self-improvement, love, etc and some people actually try to read them. They are a waste of time, mostly.   When you start reading a dozen books on finance you realize that they all say the same stuff.   You are not going to live forever in the learning phase. Don't procrastinate by reading bull-shit or the same good knowledge in 10 books. What we ought to do is choose wisely.   Yes. A good book can change your life, given you do what it asks you to do.   All the books I have named up to now are worthy of reading. Tim Ferriss, Simon Sinek, Robert Greene — these guys are worthy of reading. These guys teach what others don't. Their books are unique and actually, come from relevant and successful people.   When Richard Branson writes a book about entrepreneurship, go read it. Every line in that book is said by one of the greatest entrepreneurs of our time.   When a Chinese millionaire( he claims to be) Youtuber who releases a video titled “Why reading books keeps you broke” and a year later another one “My recommendation of books for grand success” you should be wise to tell him to jump from Victoria Falls.   These self-improvement gurus sell you delusions.   They say they have those little tricks that only they know that if you use, everything in your life will be perfect. Those little tricks. We are just “making of a to-do-list before sleeping” away from becoming the next Bill Gates.   There are no little tricks.   There is no success-mantra.   Self-improvement is a trap for 99% of the people. You can't do that unless you are very, very strong.   If you are looking for easy ways, you will only keep wasting your time forgetting that your time on this planet is limited, as alive humans that is.   Also, I feel that people who claim to read like a book a day or promote it are idiots. You retain nothing. When you do read a good book, you read slow, sometimes a whole paragraph, again and again, dwelling on it, trying to internalize its knowledge. You try to understand. You think. It takes time.   It's better to read a good book 10 times than 1000 stupid ones.   So be choosy. Read from the guys who actually know something, not some wannabe ‘influencers’.   Edit: Think And Grow Rich was written as a result of a project assigned to Napoleon Hill by Andrew Carnegie(the 2nd richest man in recent history). He was asked to study the most successful people on the planet and document which characteristics made them great. He did extensive work in studying hundreds of the most successful people of that time. The result was that little book.   Nowadays some people just study Instagram algorithms and think of themselves as a Dale Carnegie or Anthony Robbins. By Nupur Nishant, Quora Profits from free accurate cryptos signals: https://www.predictmag.com/    
    • there is no avoiding loses to be honest, its just how the market is. you win some and hopefully more, but u do lose some. 
    • $CSCO Cisco Systems stock, nice top of range breakout, from Stocks to Watch at https://stockconsultant.com/?CSCOSEPN Septerna stock watch for a bottom breakout, good upside price gap
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.