Jump to content

Welcome to the new Traders Laboratory! Please bear with us as we finish the migration over the next few days. If you find any issues, want to leave feedback, get in touch with us, or offer suggestions please post to the Support forum here.

  • Welcome Guests

    Welcome. You are currently viewing the forum as a guest which does not give you access to all the great features at Traders Laboratory such as interacting with members, access to all forums, downloading attachments, and eligibility to win free giveaways. Registration is fast, simple and absolutely free. Create a FREE Traders Laboratory account here.

clbradley

Triangle Pattern Indicator Code Not Working

Recommended Posts

Hey. Have tried this older Triangle Pattern Code I found on the net for Tradestation, but apparently the code has changed, and it doesn't recognize the word triangle. Can anyone help? Thanks.

 

Here's the code, indicator's at the bottom, function at the top:

 

Triangle Pattern Indicator by Walt Downs

 

Origin: omega-list

Written by: Walt Downs

Date found: 1 dec 97

 

Indicator calculates triangles based on SwingHighs and lows of a 10 day range, and with a swing strength of "1". Larger

triangles can be calculated by increasing the strength and/or HighestBar/LowestBar range settings. The indicator plots

a simple "spike" graph, alerting the trader to the presence of a triangle. The trader can then apply logical trendlines to establish break-out points.

 

 

 

Type : Function, Name : Triangle Pattern Indicator

 

input:

OccurH1(numericsimple),OccurH2(numericsimple),OccurL1(numericsimple),

OccurL2(numericsimple),PriceH1(numericseries),PriceH2(numericseries),

PriceL1(numericseries),PriceL2(numericseries),StrenH(numericsimple),

StrenL(numericsimple),Len(numericsimple);

 

value1 = SwingHighBar(OccurH1,PriceH1,StrenH,Len);

value2 = SwingHighBar(OccurH2,PriceH2,StrenH,Len);

value3 = SwingLowBar(OccurL1,PriceL1,StrenL,Len);

value4 = SwingLowBar(OccurL2,PriceL2,StrenL,Len);

 

 

Condition1 = high of value2 bars ago > high of value1 bars ago;

Condition2 = low of value4 bars ago < low of value3 bars ago;

Condition3 = HighestBar(H,Len) = value2;

Condition4 = LowestBar(low,Len) = value4;

 

if

Condition1 and

Condition2 and

Condition3 and

Condition4

then Triangle = true

else Triangle = false;

 

 

 

 

 

Type : Indicator, Name : Triangle Pattern Indicator

 

input:

OccurH1(1),

OccurH2(2),

OccurL1(1),

OccurL2(2),

PriceH1(high),

PriceH2(high),

PriceL1(low),

PriceL2(low),

StrenH(1),

StrenL(1),

Len(10);

 

if

Triangle(OccurH1,OccurH2,OccurL1,OccurL2,PriceH1,

PriceH2,PriceL1,PriceL2,StrenH,StrenL,Len)

= true then plot1(10,"TriFinder")

else plot1(0,"TriFinder");

 

if

Triangle(OccurH1,OccurH2,OccurL1,OccurL2,PriceH1,PriceH2,

PriceL1,PriceL2,StrenH,StrenL,Len)

= true then Alert = true;

Share this post


Link to post
Share on other sites

I made the function Triangle as you noted, yet keep getting an error message that says "Arithmetic (numeric) expression expected here". It is alluding to the word "true" in the 2nd to last sentence, "then Triangle = true"

 

It will probably say the same thing for false once I fix true. What Arithmetic (numeric) expression should I use instead of true or false near the end of the function code?

Thanks.

 

Curtis

Share this post


Link to post
Share on other sites

I am trying to verify, and if there were no errors (this box says Grammar error), then it says verification successful and no problem. This grammar error it blacks out the word "true" (and I tried replacing it with "TrueFalse" and get the same Grammor error message) and within the Grammar error box it says "Arithmetic (numeric) expression expected here. Underneath that you click a little box that says OK, and it just leaves you to figure out what to put instead of the blacked over true or TrueFalse, because they don't work. Have the 2nd to most recent platform, see one just came out within the last week, have Tradestation 8.4 (Build 1693). Try it if you're not sure, but it won't verify for me with true or TrueFalse there near the end after "then Triangle =". It seems to want a # I'm guessing by the "Arithmetic (numeric) expression expected here" message. Thanks for any help.

 

Curtis

Share this post


Link to post
Share on other sites
I am trying to verify, and if there were no errors (this box says Grammar error), then it says verification successful and no problem. This grammar error it blacks out the word "true" (and I tried replacing it with "TrueFalse" and get the same Grammor error message) and within the Grammar error box it says "Arithmetic (numeric) expression expected here. Underneath that you click a little box that says OK, and it just leaves you to figure out what to put instead of the blacked over true or TrueFalse, because they don't work. Have the 2nd to most recent platform, see one just came out within the last week, have Tradestation 8.4 (Build 1693). Try it if you're not sure, but it won't verify for me with true or TrueFalse there near the end after "then Triangle =". It seems to want a # I'm guessing by the "Arithmetic (numeric) expression expected here" message. Thanks for any help.

 

Curtis

 

To be honest, I have no idea what you are saying above, but attached is the code for the function and the indicator in .els format. I only have Tradestation 2000 but I guess TS 8.4 would be able to import .els files. Both compiled and I was able to apply the indicator to a chart, but I did not check if it shows anything meaningful.

TRIANGLE.zip

Share this post


Link to post
Share on other sites

Thanks for trying to help Tams and sevensa, but uploaded the function and indicator from your ELS, tried to use it, and get a TS box that says "study not verified". So I opened the indicator and tried to verify, and it said "Error found in function", and blacked over the word Triangle. So they must have changed what Easy Language (that's a laugh) is recognized between your platform and the more recent ones. Thanks again.

 

Curtis

Share this post


Link to post
Share on other sites
Thanks for trying to help Tams and sevensa, but uploaded the function and indicator from your ELS, tried to use it, and get a TS box that says "study not verified". So I opened the indicator and tried to verify, and it said "Error found in function", and blacked over the word Triangle. So they must have changed what Easy Language (that's a laugh) is recognized between your platform and the more recent ones. Thanks again.

Curtis

 

1. every time you import, you must verify the codes before they can be used.

(another term for verify is "compile").

 

2. please first delete the "Triangle" function from your computer. The function needs to be set to TrueFalse. This will be done automatically when you import from ELS.

 

I have imported the above codes to MultiCharts and they compile with no problem.

Share this post


Link to post
Share on other sites

Sorry, Multicharts is very different from TS. Things and words that worked on a previous platform at TS won't work on a newer one, and have found that it won't recognnize several words frequently in older codes, and this one is from 1997. I did delete everything, and someone at TS told me to change the function from numeric while starting a new one, to boolean (true/false), and that function verified, and so did the indicator, and tried to use it on a chart, nothing showed up, but received a pop up TS events log that stated "tried to reference future data". May just have to do without this indicator, it just doesn't seem compatible for the latest platform of TS with this code. Thanks for your help.

 

Curtis

Share this post


Link to post
Share on other sites

I would persevere. The fact it works for Tams & Svensa suggests it is not a problem with the indicator.

 

When it comes to easy language MC & TS are not very different. Quite the reverse.

 

Edit: There does appear to be bug in the codes logic in so far as it references a bar in the future.

Edited by BlowFish

Share this post


Link to post
Share on other sites
Sorry, Multicharts is very different from TS. Things and words that worked on a previous platform at TS won't work on a newer one, and have found that it won't recognnize several words frequently in older codes, and this one is from 1997. I did delete everything, and someone at TS told me to change the function from numeric while starting a new one, to boolean (true/false), and that function verified, and so did the indicator, and tried to use it on a chart, nothing showed up, but received a pop up TS events log that stated "tried to reference future data". May just have to do without this indicator, it just doesn't seem compatible for the latest platform of TS with this code. Thanks for your help.

Curtis

 

The indicator and function VERIFIED !

That's the important thing; that means the code was good.

You have achieved a mile stone.

Congratulations,

Give yourself a pad on the back.

 

The error message "tried to reference future data" means the indicator is a very sensitive one: you need to adjust the variables to meet the chart's volatility.

 

Go into Format Study and change the "Len" to 30.

You can use this as a starting point to fine tune the indicator.

Share this post


Link to post
Share on other sites

Well, everybody is right on this one, and welcome to the forum, Curtis.

 

Every version of MC and TS is slightly different in error checking and the recent versions of TS tend to stop indicators from functioning if they attempt to reference non existing values, such as the future data that you mentioned.

 

In order to correct this, please replace the 4 lines (value1...value4) with the following code fragment in the Triangle function:

 

if SwingHighBar(OccurH1,PriceH1,StrenH,Len) <> -1 then
value1 = SwingHighBar(OccurH1,PriceH1,StrenH,Len);
if SwingHighBar(OccurH2,PriceH2,StrenH,Len) <> -1 then
value2 = SwingHighBar(OccurH2,PriceH2,StrenH,Len);
if SwingLowBar(OccurL1,PriceL1,StrenL,Len) <> -1 then
value3 = SwingLowBar(OccurL1,PriceL1,StrenL,Len);
if SwingLowBar(OccurL2,PriceL2,StrenL,Len) <> -1 then
value4 = SwingLowBar(OccurL2,PriceL2,StrenL,Len);

 

Alternatively, use this revised Triangle function:

[LegacyColorValue = true]; 

input:
OccurH1(numericsimple),OccurH2(numericsimple),OccurL1(numericsimple),
OccurL2(numericsimple),PriceH1(numericseries),PriceH2(numericseries),
PriceL1(numericseries),PriceL2(numericseries),StrenH(numericsimple),
StrenL(numericsimple),Len (numericsimple);

if SwingHighBar(OccurH1,PriceH1,StrenH,Len) <> -1 then
value1 = SwingHighBar(OccurH1,PriceH1,StrenH,Len);
if SwingHighBar(OccurH2,PriceH2,StrenH,Len) <> -1 then
value2 = SwingHighBar(OccurH2,PriceH2,StrenH,Len);
if SwingLowBar(OccurL1,PriceL1,StrenL,Len) <> -1 then
value3 = SwingLowBar(OccurL1,PriceL1,StrenL,Len);
if SwingLowBar(OccurL2,PriceL2,StrenL,Len) <> -1 then
value4 = SwingLowBar(OccurL2,PriceL2,StrenL,Len);


Condition1 = high of value2 bars ago > high of value1 bars ago;
Condition2 = low of value4 bars ago < low of value3 bars ago;
Condition3 = HighestBar(H,Len) = value2;
Condition4 = LowestBar(low,Len) = value4;

if 
Condition1 and
Condition2 and
Condition3 and
Condition4
then Triangle = true
else Triangle = false;

Share this post


Link to post
Share on other sites
Tams, did you get a plot error in MC, trying to reference future data -1 error? I did, so just wondering if you knew how to solve the error. I tried adding more space on it, but still error?

Thanks

you can see my post above.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Topics

  • Posts

    • MNST Monster Beverage stock, top of range breakout above 60.45, from Stocks to Watch at https://stockconsultant.com/?MNST
    • there is no avoiding loses to be honest, its just how the market is. you win some and hopefully more, but u do lose some. 
    • Date: 11th July 2025.   Demand For Gold Rises As Trump Announces Tariffs!   Gold prices rose significantly throughout the week as investors took advantage of the 2.50% lower entry level. Investors also return to the safe-haven asset as the US trade policy continues to escalate. As a result, investors are taking a more dovish tone. The ‘risk-off’ appetite is also something which can be seen within the stock market. The NASDAQ on Thursday took a 0.90% dive within only 30 minutes.   Trade Tensions Escalate President Trump has been teasing with new tariffs throughout the week. However, the tariffs were confirmed on Thursday. A 35% tariff on Canadian imports starting August 1st, along with 50% tariffs on copper and goods from Brazil. Some experts are advising that Brazil has been specifically targeted due to its association with the BRICS.   However, the President has not directly associated the tariffs with BRICS yet. According to President Trump, Brazil is targeting US technology companies and carrying out a ‘witch hunt’against former Brazilian President Jair Bolsonaro, a close ally who is currently facing prosecution for allegedly attempting to overturn the 2022 Brazilian election.   Although Brazil is one of the largest and fastest-growing economies in the Americas, it is not the main concern for investors. Investors are more concerned about Tariffs on Canada. The White House said it will impose a 35% tariff on Canadian imports, effective August 1st, raised from the earlier 25% rate. This covers most goods, with exceptions under USMCA and exemptions for Canadian companies producing within the US.   It is also vital for investors to note that Canada is among the US;’s top 3 trading partners. The increase was justified by Trump citing issues like the trade deficit, Canada’s handling of fentanyl trafficking, and perceived unfair trade practices.   The President is also threatening new measures against the EU. These moves caused US and European stock futures to fall nearly 1%, while the Dollar rose and commodity prices saw small gains. However, the main benefactor was Silver and Gold, which are the two best-performing metals of the day.   How Will The Fed Impact Gold? The FOMC indicated that the number of members warming up to the idea of interest rate cuts is increasing. If the Fed takes a dovish tone, the price of Gold may further rise. In the meantime, the President pushing for a 3% rate cut sparked talk of a more dovish Fed nominee next year and raised worries about future inflation.   Meanwhile, jobless claims dropped for the fourth straight week, coming in better than expected and supporting the view that the labour market remains strong after last week’s solid payroll report. Markets still expect two rate cuts this year, but rate futures show most investors see no change at the next Fed meeting. Gold is expected to finish the week mostly flat.       Gold 15-Minute Chart     If the price of Gold increases above $3,337.50, buy signals are likely to materialise again. However, the price is currently retracing, meaning traders are likely to wait for regained momentum before entering further buy trades. According to HSBC, they expect an average price of $3,215 in 2025 (up from $3,015) and $3,125 in 2026, with projections showing a volatile range between $3,100 and $3,600   Key Takeaway Points: Gold Rises on Safe-Haven Demand. Gold gained as investors reacted to rising trade tensions and market volatility. Canada Tariffs Spark Concern. A 35% tariff on Canadian imports drew attention due to Canada’s key trade role. Fed Dovish Shift Supports Gold. Growing expectations of rate cuts and Trump’s push for a 3% cut boosted the gold outlook. Gold Eyes Breakout Above $3,337.5. Price is consolidating; a move above $3,337.50 could trigger new buy signals. Always trade with strict risk management. Your capital is the single most important aspect of your trading business.   Please note that times displayed based on local time zone and are from time of writing this report.   Click HERE to access the full HFM Economic calendar.   Want to learn to trade and analyse the markets? Join our webinars and get analysis and trading ideas combined with better understanding of how markets work. Click HERE to register for FREE!   Click HERE to READ more Market news.   Michalis Efthymiou HFMarkets   Disclaimer: This material is provided as a general marketing communication for information purposes only and does not constitute an independent investment research. Nothing in this communication contains, or should be considered as containing, an investment advice or an investment recommendation or a solicitation for the purpose of buying or selling of any financial instrument. All information provided is gathered from reputable sources and any information containing an indication of past performance is not a guarantee or reliable indicator of future performance. Users acknowledge that any investment in Leveraged Products is characterized by a certain degree of uncertainty and that any investment of this nature involves a high level of risk for which the users are solely responsible and liable. We assume no liability for any loss arising from any investment made based on the information provided in this communication. This communication must not be reproduced or further distributed without our prior written permission.
    • Back in the early 2000s, Netflix mailed DVDs to subscribers.   It wasn’t sexy—but it was smart. No late fees. No driving to Blockbuster.   People subscribed because they were lazy. Investors bought the stock because they realized everyone else is lazy too.   Those who saw the future in that red envelope? They could’ve caught a 10,000%+ move.   Another story…   Back in the mid-2000s, Amazon launched Prime.   It wasn’t flashy—but it was fast.   Free two-day shipping. No minimums. No hassle.   People subscribed because they were impatient. Investors bought the stock because they realized everyone hates waiting.   Those who saw the future in that speedy little yellow button? They could’ve caught another 10,000%+ move.   Finally…   Back in 2011, Bitcoin was trading under $10.   It wasn’t regulated—but it worked.   No bank. No middleman. Just wallet to wallet.   People used it to send money. Investors bought it because they saw the potential.   Those who saw something glimmering in that strange orange coin? They could’ve caught a 100,000%+ move.   The people who made those calls weren’t fortune tellers. They just noticed something simple before others did.   A better way. A quiet shift. A small edge. An asymmetric bet.   The red envelope fixed late fees. The yellow button fixed waiting. The orange coin gave billions a choice.   Of course, these types of gains are rare. And they happen only once in a blue moon. That’s exactly why it’s important to notice when the conditions start to look familiar.   Not after the move. Not once it's on CNBC. But in the quiet build-up— before the surface breaks.   Enter the Blue Button Please read more here: https://altucherconfidential.com/posts/netflix-amazon-bitcoin-blue  Profits from free accurate cryptos signals: https://www.predictmag.com/ 
    • What These Attacks Look Like There are several ways you could get hacked. And the threats compound by the day.   Here’s a quick rundown:   Phishing: Fake emails from your “bank.” Click the link, give your password—game over.   Ransomware: Malware that locks your files and demands crypto. Pay up, or it’s gone.   DDoS: Overwhelm a website with traffic until it crashes. Like 10,000 bots blocking the door. Often used by nations.   Man-in-the-Middle: Hackers intercept your messages on public WiFi and read or change them.   Social Engineering: Hackers pose as IT or drop infected USB drives labeled “Payroll.”   You don’t need to be “important” to be a target.   You just need to be online.   What You Can Do (Without Buying a Bunker) You don’t have to be tech-savvy.   You just need to stop being low-hanging fruit.   Here’s how:   Use a YubiKey (physical passkey device) or Authenticator app – Ditch text message 2FA. SIM swaps are real. Hackers often have people on the inside at telecom companies.   Use a password manager (with Yubikey) – One unique password per account. Stop using your dog’s name.   Update your devices – Those annoying updates patch real security holes. Use them.   Back up your files – If ransomware hits, you don’t want your important documents held hostage.   Avoid public WiFi for sensitive stuff – Or use a VPN.   Think before you click – Emails that feel “urgent” are often fake. Go to the websites manually for confirmation.   Consider Starlink in case the internet goes down – I think it’s time for me to make the leap. Don’t Panic. Prepare. (Then Invest.)   I spent an hour in that basement bar reading about cyberattacks—and watching real-world systems fall apart like dominos.   The internet going down used to be an inconvenience. Now, it’s a warning.   Cyberwar isn’t coming. It’s here.   And the next time your internet goes out, it might not just be your router.   Don’t panic. Prepare.   And maybe keep a backup plan in your back pocket. Like a local basement bar with good bourbon—and working WiFi.   As usual, we’re on the lookout for more opportunities in cybersecurity. Stay tuned.   Author: Chris Campbell (AltucherConfidential) Profits from free accurate cryptos signals: https://www.predictmag.com/   
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.