Jump to content

Welcome to the new Traders Laboratory! Please bear with us as we finish the migration over the next few days. If you find any issues, want to leave feedback, get in touch with us, or offer suggestions please post to the Support forum here.

  • Welcome Guests

    Welcome. You are currently viewing the forum as a guest which does not give you access to all the great features at Traders Laboratory such as interacting with members, access to all forums, downloading attachments, and eligibility to win free giveaways. Registration is fast, simple and absolutely free. Create a FREE Traders Laboratory account here.

lonew0lf

ZigZag Indicator Enhancement

Recommended Posts

I found this useful zigzag indicator off elittrader.com and wanted to know how I would go about adding Fibonacci ratios to each high/low swing. Thoughts and comments welcome.

 

// ZigZag JJs

//

//

// pls post your comments and enhancements here:

//

//

 

inputs:

ATRPeriod(9), //Number of ATR Periods

ATRMulti(2.0), // ATR Multiplier

StrengthSensitivity(2), //Pivot Strength

ShowZigZagLines(True),

ZigZagLineColorUp(black),

ZigZagLineColorDN(black),

ZigZagLineWidth(.1),

ZigZagLineStyle(tool_solid),

ZigZagTextColor(black),

VertOffset1(1),

VertOffset2(2), // Second String on Swing Hi/Lows

DecimalPlaces(2);

 

 

vars:

NewSwingPrice(0),

LastSwingPrice(0),

SwingPrice(High),

SwingDate(Date),

SwingTime(time_s),

TLDir(0), { TLDir = -1 implies prev TL dn, +1 implies prev TL up }

SaveSwing(false),

AddTL(false),

UpdateTL(false),

TLRef(0),

TLSwing(0),

Diff(0),

ArrayMax (17),

ATRPoints(0),

BarDiff(0), TimeDiff(0),

ZigZagCount(0),

x(0);

 

Arrays:

TrendLine[17] (0), DayValue[17] (0), ZigZag[1000,3](0);

 

if CurrentBar = 1 then

begin

for x=0 to ArrayMax { Draw Fib Lines }

begin

if x <= ArrayMax then

begin

 

TrendLine[x] = TL_New_s (Date[1], time_s[1], Low, Date, time_s, Low);

TL_SetExtLeft (TrendLine[x], false);

TL_SetExtRight (TrendLine[x], True);

 

end; // if

 

end; // for

 

end; //if currentbar

 

{ Candidate swings are just-confirmed, 3-bar (Str=1), SwingHi's and SwingLo's }

 

NewSwingPrice = SwingHigh( 1, High, StrengthSensitivity, StrengthSensitivity+1);

ATRPoints = ATRMulti*AvgTrueRange(ATRPeriod) ;

 

if NewSwingPrice <> -1 then

begin

if (TLDir <= 0 and NewSwingPrice >= SwingPrice + ATRPoints) then

 

{ prepare to add new up TL }

 

begin

SaveSwing = true;

AddTL = true;

TLDir = 1;

end

else

if TLDir = 1 and NewSwingPrice >= SwingPrice then { prepare to update prev up TL }

begin

 

SaveSwing = true;

UpdateTL = true;

end;

end

else

 

begin

 

{ NewSwingPrice = SwingLow( 1, Low, 1, 2 ); }

 

NewSwingPrice = SwingLow( 1, Low, StrengthSensitivity, StrengthSensitivity+1);

if NewSwingPrice <> -1 then

begin { prepare to add new dn TL }

 

if TLDir >= 0 and NewSwingPrice <= SwingPrice - ATRPoints then

begin

 

SaveSwing = true;

AddTL = true;

TLDir = -1;

end

else

if TLDir = -1 and NewSwingPrice <= SwingPrice then { prepare to update prev dn TL }

begin

SaveSwing = true;

UpdateTL = true ;

end;

end;

end;

 

 

if SaveSwing then { save new swing and reset SaveSwing }

begin

SwingPrice = NewSwingPrice ;

SwingDate = Date[strengthSensitivity];

SwingTime = time_s[strengthSensitivity];

 

// SaveSwing = false ;

end ;

 

{ add new TL and reset AddTL }

if AddTL then

begin

if ShowZigZagLines then

begin

TLRef = TL_New_s(SwingDate, SwingTime, SwingPrice, SwingDate[1], SwingTime[1],SwingPrice[1]);

TL_SetExtLeft( TLRef, false);

TL_SetExtRight( TLRef, false);

TL_SetSize( TLRef, ZigZagLineWidth);

 

if TLDir = -1 then

TL_SetColor( TLRef, ZigZagLineColorDN)

else

TL_SetColor( TLRef, ZigZagLineColorUp);

 

LastSwingPrice = SwingPrice[1];

end;

 

if (TLDir[1] <> TLDir[2]) then BarDiff = 0

else BarDiff = BarDiff +1;

 

ZigZagCount = ZigZagCount + 1;

ZigZag[ZigZagCount,1] = SwingPrice; // Current Swing Price

ZigZag[ZigZagCount,2] = BarNumber; // BarNum

ZigZag[ZigZagCount,3] = TimetoMinutes(time_s); // Time Var

BarDiff = ZigZag[ZigZagCount,2] - ZigZag[ZigZagCount-1,2];

 

if TLDir = -1 then

Diff = LastSwingPrice - SwingPrice

else

Diff = SwingPrice - LastSwingPrice;

 

TimeDiff = Zigzag[ZigZagcount,3] - Zigzag[ZigZagcount-1,3];

AddTL = false;

end

 

else

 

if UpdateTL then { update prev TL and reset UpdateTL }

begin

if ShowZigZagLines then

TL_SetEnd_s( TLRef, SwingDate, SwingTime, SwingPrice);

 

if (TLDir[1] <> TLDir[2]) then BarDiff = 0

else BarDiff = BarDiff +1;

 

ZigZag[ZigZagCount,1] = SwingPrice; // Current Swing Price

ZigZag[ZigZagCount,2] = BarNumber[1]; // BarNum

ZigZag[ZigZagCount,3] = TimetoMinutes(time_s); // Time Var

 

BarDiff = ZigZag[ZigZagCount,2] - ZigZag[ZigZagCount-1,2];

 

if TLDir = -1 then

Diff = LastSwingPrice - SwingPrice

else

Diff = SwingPrice - LastSwingPrice;

 

TimeDiff = Zigzag[ZigZagcount,3] - Zigzag[ZigZagcount-1,3];

UpdateTL = false;

 

end;

 

 

if SaveSwing then

begin

if TLDir = -1 then

begin

DayValue[0] = Swingprice;

DayValue[1] = LastSwingprice;

 

end

else

begin

DayValue[1] = Swingprice;

DayValue[0] = LastSwingprice;

end;

 

Diff = DayValue[0] - DayValue[1];

 

for x=0 to ArrayMax

begin

if TrendLine[x] > 0 then

begin

 

{ SetEnd before SetBegin }

 

TL_SetEnd_s (TrendLine[x], Date, time_s, DayValue[x]);

TL_SetBegin_s (TrendLine[x], Date, time_s, DayValue[x]);

 

end; // if TrendLine

 

end; // for loop

 

SaveSwing = False;

 

end; // if SaveSwing

Share this post


Link to post
Share on other sites
Tams - it might be easier to show with a couple charts. The arrows are pointing to what i'd like to accomplish off the zigzag swings.

 

yup, that can easily be done.

 

.

Edited by Tams

Share this post


Link to post
Share on other sites

fibo is only a "number".

 

a number is a calculation of some sort.

 

if you can figure out that "sort".... which is no rocket science in this case (fibo=percentage),

 

the next task is to post the number to the turning point.

 

locating that "point" is no big deal either,

because the point is already calculated (the trendline turning point).

 

so all you needed to do is piggyback onto the turning with the fibo number.

 

QED

Share this post


Link to post
Share on other sites

Hello,

 

I saw your ZigZac Indicator, and think it is the same I am looking for. I do not know, if it is common to ask, but would you be so kind to send the ZigZag with Fibo to me?

 

"I found this useful zigzag indicator off elittrader.com and wanted to know how I would go about adding Fibonacci ratios to each high/low swing. Thoughts and comments welcome."

 

I started with TradeStation and i have no idea to programm yet. The zigzag in TradeStation has the problem, that it use "close" but not "high or low" to calculate. For me this seems to be different here.

 

I would be happy to hear from you.

 

TQ

Share this post


Link to post
Share on other sites
Hello,

 

I saw your ZigZac Indicator, and think it is the same I am looking for. I do not know, if it is common to ask, but would you be so kind to send the ZigZag with Fibo to me?

 

"I found this useful zigzag indicator off elittrader.com and wanted to know how I would go about adding Fibonacci ratios to each high/low swing. Thoughts and comments welcome."

 

I started with TradeStation and i have no idea to programm yet. The zigzag in TradeStation has the problem, that it use "close" but not "high or low" to calculate. For me this seems to be different here.

 

I would be happy to hear from you.

 

TQ

 

the code is already posted in the thread.

please read.

Share this post


Link to post
Share on other sites

Sorry Tams,

 

where can i find such indicators here. I do not know how to search the signle different indicators. I am not very common in programming, therefore i cannot judge, what is in or what the indicator does from the sight of programming.

 

I am looking for people how can programm my ideas. Where can i post my ideas to get hints and help.

 

Thank you very much

TQ

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Topics

  • Posts

    • Be careful who you blame.   I can tell you one thing for sure.   Effective traders don’t blame others when things start to go wrong.   You can hang onto your tendency to play the victim, or the martyr… but if you want to achieve in trading, you have to be prepared to take responsibility.   People assign reasons to outcomes, whether based on internal or external factors.   When traders face losses, it's common for them to blame bad luck, poor advice, or other external factors, rather than reflecting on their own personal attributes like arrogance, fear, or greed.   This is a challenging lesson to grasp in your trading journey, but one that holds immense value.   This is called attribution theory. Taking responsibility for your actions is the key to improving your trading skills. Pause and ask yourself - What role did I play in my financial decisions?   After all, you were the one who listened to that source, and decided to act on that trade based on the rumour. Attributing results solely to external circumstances is what is known as having an ‘external locus of control’.   It's a concept coined by psychologist Julian Rotter in 1954. A trader with an external locus of control might say, "I made a profit because the markets are currently favourable."   Instead, strive to develop an "internal locus of control" and take ownership of your actions.   Assume that all trading results are within your realm of responsibility and actively seek ways to improve your own behaviour.   This is the fastest route to enhancing your trading abilities. A trader with an internal locus of control might proudly state, "My equity curve is rising because I am a disciplined trader who faithfully follows my trading plan." Author: Louise Bedford Source: https://www.tradinggame.com.au/
    • SELF IMPROVEMENT.   The whole self-help industry began when Dale Carnegie published How to Win Friends and Influence People in 1936. Then came other classics like Think And Grow Rich by Napoleon Hill, Awaken the Giant Within by Tony Robbins toward the end of the century.   Today, teaching people how to improve themselves is a business. A pure ruthless business where some people sell utter bullshit.   There are broke Instagrammers and YouTubers with literally no solid background teaching men how to be attractive to women, how to begin a start-up, how to become successful — most of these guys speaking nothing more than hollow motivational words and cliche stuff. They waste your time. Some of these people who present themselves as hugely successful also give talks and write books.   There are so many books on financial advice, self-improvement, love, etc and some people actually try to read them. They are a waste of time, mostly.   When you start reading a dozen books on finance you realize that they all say the same stuff.   You are not going to live forever in the learning phase. Don't procrastinate by reading bull-shit or the same good knowledge in 10 books. What we ought to do is choose wisely.   Yes. A good book can change your life, given you do what it asks you to do.   All the books I have named up to now are worthy of reading. Tim Ferriss, Simon Sinek, Robert Greene — these guys are worthy of reading. These guys teach what others don't. Their books are unique and actually, come from relevant and successful people.   When Richard Branson writes a book about entrepreneurship, go read it. Every line in that book is said by one of the greatest entrepreneurs of our time.   When a Chinese millionaire( he claims to be) Youtuber who releases a video titled “Why reading books keeps you broke” and a year later another one “My recommendation of books for grand success” you should be wise to tell him to jump from Victoria Falls.   These self-improvement gurus sell you delusions.   They say they have those little tricks that only they know that if you use, everything in your life will be perfect. Those little tricks. We are just “making of a to-do-list before sleeping” away from becoming the next Bill Gates.   There are no little tricks.   There is no success-mantra.   Self-improvement is a trap for 99% of the people. You can't do that unless you are very, very strong.   If you are looking for easy ways, you will only keep wasting your time forgetting that your time on this planet is limited, as alive humans that is.   Also, I feel that people who claim to read like a book a day or promote it are idiots. You retain nothing. When you do read a good book, you read slow, sometimes a whole paragraph, again and again, dwelling on it, trying to internalize its knowledge. You try to understand. You think. It takes time.   It's better to read a good book 10 times than 1000 stupid ones.   So be choosy. Read from the guys who actually know something, not some wannabe ‘influencers’.   Edit: Think And Grow Rich was written as a result of a project assigned to Napoleon Hill by Andrew Carnegie(the 2nd richest man in recent history). He was asked to study the most successful people on the planet and document which characteristics made them great. He did extensive work in studying hundreds of the most successful people of that time. The result was that little book.   Nowadays some people just study Instagram algorithms and think of themselves as a Dale Carnegie or Anthony Robbins. By Nupur Nishant, Quora Profits from free accurate cryptos signals: https://www.predictmag.com/    
    • there is no avoiding loses to be honest, its just how the market is. you win some and hopefully more, but u do lose some. 
    • $CSCO Cisco Systems stock, nice top of range breakout, from Stocks to Watch at https://stockconsultant.com/?CSCOSEPN Septerna stock watch for a bottom breakout, good upside price gap
    • $CSCO Cisco Systems stock, nice top of range breakout, from Stocks to Watch at https://stockconsultant.com/?CSCOSEPN Septerna stock watch for a bottom breakout, good upside price gap
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.