Welcome to the new Traders Laboratory! Please bear with us as we finish the migration over the next few days. If you find any issues, want to leave feedback, get in touch with us, or offer suggestions please post to the Support forum here.

• ## Welcome Guests

Welcome. You are currently viewing the forum as a guest which does not give you access to all the great features at Traders Laboratory such as interacting with members, access to all forums, downloading attachments, and eligibility to win free giveaways. Registration is fast, simple and absolutely free. Create a FREE Traders Laboratory account here.

# Color Code MA for Range Bar Indicator

## Recommended Posts

I'm stuck on what I thought would be a simple coding task for Uli's range bar expansion indicator.

My goal was to color code the two moving averages EMA34 and LSMA red and magenta respectively when slope is down; green and blue when slope is up. Full original code is posted below.

My attempt to color code EMA34 by it's slope (shown next) failed:

original plot line (17 lines from the end):

if plotEMA34 then plot1[1](EMA34[value1],"LBEMA34")

my failed code attempt (just turns MA green):

if plotema34 and

EMA34[value1] > EMA34[value1-1]then

plot1[1](EMA34[value1],"LBEMA34",Green)

else if

plotema34 and

EMA34[value1] < EMA34[value1-1]then

plot1[1](EMA34[value1],"LBEMA34",red);

I believe the problem has to do with the fact that this is built within an array.

Any savy coders able to lend some ideas?

snowbird

-------------------------------------------------

//Range Expansion Bars by Uli Schmuli

inputs: BarRange(3.75),

PlotRangeBars(true),

PlotExpansionBars(true),

PlotExpansionPotential(true),

BullBarColor(green),

BearBarColor(red),

RBThickness(3),

PlotEMA34(true),

PlotLSMA(true);

var:RangeHigh(0),

RangeLow(0),

RangeOpen(open),

RangeClose(0),

RBcolor(green),

LBLow(0),

LBHigh(0),

LBOpen(0),

LBClose(0),

offset(0),

LBxAvg(0),

SmoothingFactor(2/35),

LSMAtemp(0);

Array: EMA34[100](0),

RBHigh[100](close),

RBLow[100](close),

RBOpen[100](Close),

RBClose[100](close),

LSMA[100](close);

if barnumber = 1 then //1st bar initialization

begin

if range < BarRange then

begin

RangeHigh = high;

RangeLow = Low;

end;

if range > BarRange then

begin

RangeHigh = High;

RangeLow = Low;

end;

LSMA[1] = close;

EMA34[1] = close;

RBclose[1] = close;

LSMA[1] = close;

LBopen = open;

end else //all other bars

Begin

if date <> date[1] then //new day, begin new bar & close out prior bar

begin

LBHigh = RangeHigh;

LBlow = RangeLow;

LBOpen = RangeOpen;

LBclose = iff(close<RBclose[1],RangeLow,RangeHigh);

For Value1 = 100 downto 2

begin

EMA34[value1] = EMA34[value1-1];

RBHigh[value1] = RBHigh[Value1-1];

RBLow[value1] = RBLow[Value1-1];

RBOpen[value1] = RBOpen[Value1-1];

RBClose[value1] = RBClose[value1-1];

LSMA[value1] = LSMA[value1-1];

end;

RBHigh[1] = LBHigh;

RBLow[1] = LBLow;

RBOpen[1] = LBOpen;

RBClose[1] = LBClose;

EMA34[1] = EMA34[2] + SmoothingFactor * (RBclose[1] - EMA34[2]);

value1 = LinRegArray(RBClose,25, 0, value2, value3,value4, LSMAtemp);

LSMA[1] = LSMAtemp;

RangeOpen = Open;

RangeHigh = High;

RangeLow = low;

RangeClose = close;

offset = 1;

end;

if offset[1] = 1 and date = date[1] then offset = 0;

if low >= rangelow and high <= rangehigh then //Bar totally in barrange

begin

end;

if high > Rangehigh and low >= rangelow then //new high value

begin

rangehigh = high;

If high - rangelow > barrange then //New Higher bar detected

begin

LBlow = RangeLow;

LBHigh = RangeLow + BarRange;

LBOpen = RangeOpen;

LBclose = LBHigh;

For Value1 = 100 downto 2

begin

EMA34[value1] = EMA34[value1-1];

RBHigh[value1] = RBHigh[Value1-1];

RBLow[value1] = RBLow[Value1-1];

RBOpen[value1] = RBOpen[Value1-1];

RBClose[value1] = RBClose[value1-1];

LSMA[value1] = LSMA[value1-1];

end;

RBHigh[1] = LBHigh;

RBLow[1] = LBLow;

RBOpen[1] = LBOpen;

RBClose[1] = LBClose;

EMA34[1] = EMA34[2] + SmoothingFactor * (RBclose[1] - EMA34[2]);

value1 = LinRegArray(RBClose,25, 0, value2, value3,value4, LSMAtemp);

LSMA[1] = LSMAtemp;

rangeopen = Rangelow + barrange;

rangeLow = Rangelow + barrange;

RangeClose = rangeopen;

offset = 1;

end;

end;

if low < RangeLow and high <= rangehigh then//new low value

begin

Rangelow = low;

if rangehigh - low > barrange then //New lower bar detected

begin

LBHigh = RangeHigh;

LBlow = RangeHigh - barrange;

LBOpen = RangeOpen;

LBclose = LBlow;

For Value1 = 100 downto 2

begin

EMA34[value1] = EMA34[value1-1];

RBHigh[value1] = RBHigh[Value1-1];

RBLow[value1] = RBLow[Value1-1];

RBOpen[value1] = RBOpen[Value1-1];

RBClose[value1] = RBClose[value1-1];

LSMA[value1] = LSMA[value1-1];

end;

RBHigh[1] = LBHigh;

RBLow[1] = LBLow;

RBOpen[1] = LBOpen;

RBClose[1] = LBClose;

EMA34[1] = EMA34[2] + SmoothingFactor * (RBclose[1] - EMA34[2]);

value1 = LinRegArray(RBClose,25, 0, value2, value3,value4, LSMAtemp);

LSMA[1] = LSMAtemp;

RangeOpen = LBclose;

RangeHigh = LBclose;

RangeLow = low;

RangeClose = close;

offset = 1;

end;

end;

if high > RangeHigh and Low < RangeLow and rangehigh - rangelow > barrange then//engulfing bar

begin

RangeLow = low;

RangeHigh = high;

end;

end;

begin

if offset = 1 then //new bar begun

begin

if RBclose[1] < RBclose[2] then RBcolor = BearBarColor else RBcolor = BullBarColor;

plot15[1](RBHigh[value1],"RBHighL",RBColor,default,RBthickness);

plot16[1](RBLow[value1],"RBLowL",RBcolor,default,RBthickness);

plot17[1](RBopen[value1],"RBopenL",RBcolor,default,RBthickness);

Plot18[1](RBClose[value1],"RBcloseL",RBColor,default,RBthickness);

if plotEMA34 then plot1[1](EMA34[value1],"LBEMA34")

if plotLSMA then plot5[1](LSMA[Value1],"LSMA");

end;

if close < LBclose then RBcolor = darkred else RBcolor = darkgreen;

if PlotExpansionBars then

begin

plot20(rangehigh,"chigh",RBColor,default,1);

plot21(rangelow,"clow",RBcolor,default,1);

plot22(rangeopen,"copen",RBcolor,default,1);

Plot23(Close,"cclose",RBColor,default,1);

end;

if PlotExpansionPotential then

begin

Plot24(rangehigh-barrange,"PotLow");

Plot25(RangeLow+barrange,"PotHigh");

end;

end;

##### Share on other sites

you are making it way too complicated.

try this:

```if plotema34 then
begin
plot1[1]( EMA34[value1], "LBEMA34");

if EMA34[value1] > EMA34[value1-1] then
SetPlotColor( 1, green )
else
SetPlotColor( 1, red );
end;
```

ps. I don't understand why you use plot1[1].

##### Share on other sites

Wow... quick response TAM's!!

I was definatly making it too hard (can you tell I'm NOT a coder)

but unfortunately the code simplification still does not work (I believe it has to do either with how often Uli samples the Array, or his smoothing algorithm in line #69

EMA34[1] = EMA34[2] + SmoothingFactor * (RBclose[1] - EMA34[2]);

Don't know if this will port to MT... but that's what it might take to figure this one out... I posted a chart that shows the MA color changes in the indicator with your code... never does go red... but we do get patches of green!

I do not know why Uli uses plot1[1]... but figured it had something to do with his array setup and calculations. If you eliminate the [1] then the MA just plots green (up and down!)

snowbird

##### Share on other sites

maybe your array is not serial...

try this:

the var ema.34 should isolate the sequence.

```var:
ema.34(0);

ema.34 = EMA34[value1];

if plotema34 then
begin
plot1[1]( EMA.34, "LBEMA34");

if EMA.34 > EMA.34[1] then
SetPlotColor( 1, green )
else
SetPlotColor( 1, red );
end;
```

##### Share on other sites
...I do not know why Uli uses plot1[1]... but figured it had something to do with his array setup and calculations. If you eliminate the [1] then the MA just plots green (up and down!)

snowbird

plot[1] ... plots the previous bar.

i.e. it goes back one bar to plot the color/value.

I don't know if he is changing the color/value of the previous bar? or simply skipping the plot on the current bar.

.

Edited by Tams

##### Share on other sites

The reason plot[1] is used for the range bar is because when using tick data input, you don't know if a bar is closed until the range has been exceeded on the next bar. So, if a range has been filled, then the proper place to plot the bar is one bar back.

You do realize that range bars are now one of the chart types that can be selected, yes? In other words, range bars are now part of the Tradestation platform. I wrote this code as a workaround until they released a version that included range bars.

While is may seem that with the native range bars in Tradestation that this code is now obsolete, it does have a useful purpose. If you are running a strategy using a range bar chart, you cannot use intrabar order generation. The code I provided allows you to take action within the current bar, effectively allowing you to generate orders & other actions "intrabar."

Also, I would like to draw your attention to an error in the code. A new bar generated by this code creates a range bar that has the same open value as the prior bar close. This is not correct. The open should be 1 tick above/below the prior bar close and the bar range calculated from there.

Uli

##### Share on other sites

Thanks Uli,

I'm actually using the range "Expansion" bars which are not available in tradestation.

You will probably laugh when you hear how I am using them... My major issue is patience and discipline (I tend to jump the gun too early and overtrade).

I've been using the range expansion bars in three ways to help:

1. Don't trade the chop (blue rectangle on chart, where you get an up/down/up sequence of expanded bars

2. Wait for a "signal" range expansion bar (each of the 3 green bars in a range downtrend on this chart are what I use as "signal" bars , and then I wait for a break below the low of the previous bar in this case to enter (3 yellow arrow trend re-entries on the chart)

3. But my favorites are the breakouts from consolidations. These are where significant time elapses between range expansion bars (green and red rectangles in the chart). I try and set the expansion factor at ~2x the ATR (been thinking about possible changes to the code to make this automatic!

I was also wondering what criteria you use for color coding bars between range expansion bars?

... and as you can see... I still have not completely figured out color coding of the EMA (issue is due to the smoothing algorithm I believe).

TAMS has been a great help as I now have portions that turn both red and green... its the parts in-between I'm missing!

Thanks again,

snowbird

##### Share on other sites

can someone post codes to plot point on an indicator i.e. CCI (2nd paragraph plotted with 133 tick as data1) to show Open of Range Expansion Bar.I am using MC.

##### Share on other sites
can someone post codes to plot point on an indicator i.e. CCI (2nd paragraph plotted with 133 tick as data1) to show Open of Range Expansion Bar.I am using MC.

can you post a mock up?

##### Share on other sites

Tams, I do not know how to post mock,

##### Share on other sites

Tams, what is mock and how i post it

##### Share on other sites
Tams, what is mock and how i post it

a mock up is a hand drawn chart; a model to illustrate the position and format of your proposed plots.

for posting attachments:

when you are making reply to this post, look under the message box, you will see a section for Additional Options. Look for the "Manage Attachments" button

##### Share on other sites

Tams;

i have attched Mock . 2nd paragraph , ihave cci indicator valuecci = cci(ccilength)

circle shows cci value when LBclose and new bar begins. i wanted to plot those Point on cci when LBclose . !st paragraph has 233 tick chart as data1 and Range Expansion Bar indicator

(codes for that are posted in the begining of this topic.

##### Share on other sites

Tams ; finally Mock is attached

##### Share on other sites

follwing codes ,modified from range expension bars code provided by

snowbird. I wanted to plot point when RB close. attached codes does it but not on top of cci. dots as shown in Mock , points plotted are not aligned on top of cci indicator.

can some one help tocorrect the codes so that points can be plotted on top of cci

//Range Expansion Bars by Uli Schmuli

inputs: BarRange(3.75),ccilen(14),

PlotRangeBars(true),

PlotExpansionBars(true),

PlotExpansionPotential(true),

BullBarColor(green),

BearBarColor(red),

RBThickness(3),

PlotEMA34(true),

PlotLSMA(true);

var:RangeHigh(0),

RangeLow(0),

RangeOpen(open),

RangeClose(0),

RBcolor(green),

LBLow(0),

LBHigh(0),

LBOpen(0),

LBClose(0),

offset(0),

LBxAvg(0),

SmoothingFactor(2/35),mycci(0),

LSMAtemp(0);

Array: EMA34[100](0),

RBHigh[100](close),

RBLow[100](close),

RBOpen[100](Close),

RBClose[100](close),

LSMA[100](close),

hvalue[100](0);

mycci = cci(ccilen);

if barnumber = 1 then //1st bar initialization

begin

if range < BarRange then

begin

RangeHigh = high;

RangeLow = Low;

end;

if range > BarRange then

begin

RangeHigh = High;

RangeLow = Low;

end;

hvalue[1] = mycci;

LSMA[1] = close;

EMA34[1] = close;

RBclose[1] = close;

LSMA[1] = close;

LBopen = open;

end else //all other bars

Begin

if date <> date[1] then //new day, begin new bar & close out prior bar

begin

LBHigh = RangeHigh;

LBlow = RangeLow;

LBOpen = RangeOpen;

LBclose = iff(close<RBclose[1],RangeLow,RangeHigh);

For Value1 = 100 downto 2

begin

hvalue[value1] = hvalue[value1-1];

EMA34[value1] = EMA34[value1-1];

RBHigh[value1] = RBHigh[Value1-1];

RBLow[value1] = RBLow[Value1-1];

RBOpen[value1] = RBOpen[Value1-1];

RBClose[value1] = RBClose[value1-1];

LSMA[value1] = LSMA[value1-1];

end;

RBHigh[1] = LBHigh;

RBLow[1] = LBLow;

RBOpen[1] = LBOpen;

RBClose[1] = LBClose;

hvalue[1] = mycci;

EMA34[1] = EMA34[2] + SmoothingFactor * (RBclose[1] - EMA34[2]);

value1 = LinRegArray(RBClose,25, 0, value2, value3,value4, LSMAtemp);

LSMA[1] = LSMAtemp;

RangeOpen = Open;

RangeHigh = High;

RangeLow = low;

RangeClose = close;

offset = 1;

end;

if offset[1] = 1 and date = date[1] then offset = 0;

if low >= rangelow and high <= rangehigh then //Bar totally in barrange

begin

end;

if high > Rangehigh and low >= rangelow then //new high value

begin

rangehigh = high;

If high - rangelow > barrange then //New Higher bar detected

begin

LBlow = RangeLow;

LBHigh = RangeLow + BarRange;

LBOpen = RangeOpen;

LBclose = LBHigh;

For Value1 = 100 downto 2

begin

hvalue[value1] = hvalue[value1-1];

EMA34[value1] = EMA34[value1-1];

RBHigh[value1] = RBHigh[Value1-1];

RBLow[value1] = RBLow[Value1-1];

RBOpen[value1] = RBOpen[Value1-1];

RBClose[value1] = RBClose[value1-1];

LSMA[value1] = LSMA[value1-1];

end;

hvalue[1] = mycci;

RBHigh[1] = LBHigh;

RBLow[1] = LBLow;

RBOpen[1] = LBOpen;

RBClose[1] = LBClose;

EMA34[1] = EMA34[2] + SmoothingFactor * (RBclose[1] - EMA34[2]);

value1 = LinRegArray(RBClose,25, 0, value2, value3,value4, LSMAtemp);

LSMA[1] = LSMAtemp;

rangeopen = Rangelow + barrange;

rangeLow = Rangelow + barrange;

RangeClose = rangeopen;

offset = 1;

end;

end;

if low < RangeLow and high <= rangehigh then//new low value

begin

Rangelow = low;

if rangehigh - low > barrange then //New lower bar detected

begin

LBHigh = RangeHigh;

LBlow = RangeHigh - barrange;

LBOpen = RangeOpen;

LBclose = LBlow;

For Value1 = 100 downto 2

begin

hvalue[value1] = hvalue[value1-1];

EMA34[value1] = EMA34[value1-1];

RBHigh[value1] = RBHigh[Value1-1];

RBLow[value1] = RBLow[Value1-1];

RBOpen[value1] = RBOpen[Value1-1];

RBClose[value1] = RBClose[value1-1];

LSMA[value1] = LSMA[value1-1];

end;

RBHigh[1] = LBHigh;

RBLow[1] = LBLow;

RBOpen[1] = LBOpen;

RBClose[1] = LBClose;

hvalue[1] = mycci;

EMA34[1] = EMA34[2] + SmoothingFactor * (RBclose[1] - EMA34[2]);

value1 = LinRegArray(RBClose,25, 0, value2, value3,value4, LSMAtemp);

LSMA[1] = LSMAtemp;

RangeOpen = LBclose;

RangeHigh = LBclose;

RangeLow = low;

RangeClose = close;

offset = 1;

end;

end;

if high > RangeHigh and Low < RangeLow and rangehigh - rangelow > barrange then//engulfing bar

begin

RangeLow = low;

RangeHigh = high;

end;

end;

begin

if offset = 1 then //new bar begun

begin

if RBclose[1] < RBclose[2] then RBcolor = BearBarColor else RBcolor = BullBarColor;

plot19[1](hvalue[value1],"ccpoint",RBcolor,default,RBThickness);

end;

end;

##### Share on other sites
follwing codes ,modified from range expension bars code provided by

snowbird. I wanted to plot point when RB close. attached codes does it but not on top of cci. dots as shown in Mock , points plotted are not aligned on top of cci indicator.

can some one help tocorrect the codes so that points can be plotted on top of cci

I am not sure if I understand what you mean/want.

you can put the mock up in the Paint program and add arrows/lines to point out to the specific place you are talking about... then add notes on the chart to describe the following:

1. what the code is doing now,

2. what you want the code to do.

3. what is triggering the "highlight" on the chart.

## Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

×   Pasted as rich text.   Paste as plain text instead

Only 75 emoji are allowed.

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×

• 0
• 2
• 1
• 4
• 0