// Vertical Lines at specified time
// author: aaa
// date: 20090516
//
// to see how the market reacts everydays specially Cash Opening and NY Opening or whatever you want
// holding the mouse at the end of a lines shows intraday price High Low difference

Please, feel free to correct my code if needed

[Tams]

Nice idea!

Very structured code!




Let's examine it a bit...

If you click on the trendline and drag it to one side, you will see another trendline sitting where it was before.

If you click on that trendline and drag it to one side, you will see yet another trendline sitting there.

The reason being this section of the code:

if PlotOpenCash <> 0 and time >= OpenCash then


MC will evaluate this condition time >= OpenCash at every bar.
If this condition is TRUE, MC will draw a trendline at "OpenCash".

At the next bar, MC will evaluate this condition again.
If the condition is true, it will draw another trendline (at the same place).

MC will draw a new trendline, again and again, at the same place, until end of the day.


Although the duplicated trendlines do not affect the chart, it will consume precious CPU power.
If you have a few indicators opened, it will slow down your computer.


To fix the problem, all you have to do is take the multiple condition away:
if PlotOpenCash <> 0 and time = OpenCash then


you can do the same with OpenNewYork.

[aaa]

I was sure that they were a problem with the lines

Tams, you have Xray eyes

only > makes the difference from a wrong code to a correct code.

ThanX for the pedagogic explanation

[aaa]

Nice idea!

Very structured code!

Thanx for your words of encouragement

The most I've learned comes from this forum

And this indicator was possible only with your gentle and clever support

[Tams]

//-----------------------------------------------------
		inputs:
//----------------------------------------------------
    
	PlotOpenCash( 	1   	),
	PlotOpenNewYork( 	1   	),

I prefer to use

PlotOpenCash( True ),
PlotOpenNewYork( True ),


I found True/False is more intuitive at the Format Study window.

plus,
in EasyLanguage,

if PlotOpenCash = true then...

can be written as

if PlotOpenCash then...


1. "True" is implied.
2. the code looks cleaner without so many equal signs.



just a personal preference... makes no difference to the effectiveness of the code.

[aaa]

Dear Tams

I agree with you ; Programing is an art.

Because I'm a lazy animal..

...I write down 0/1 oftenly in the format window instead of true/False wich is more source of faults.

[aaa]

// Vertical Lines at specified time
// author: aaa
// Version 0.1
// date: 20090516
//
// date: 20090523
// Version 0.2
// Code cleaned by Tams

// to see how the market reacts everydays specially Cash Opening and NY Opening or whatever you want
// holding the mouse at the end of a lines shows intraday price High Low difference