[Tams]

Originally Posted by BlowFish »

Actually that was why I tried to help compared t0o many posters he did a reasonable job of describing what he was trying to do . He posted some code that he had taken a stab at, reasonably clearly described what he was trying to do and posted a chart with an illustration of how it looked and how it should look. Compared to many of the "please help" posts a zillion miles ahead ! I think (though I may be mistaken) there was enough information in the original post to provide a solution. Time will tell I guess!

Having said that your advice was spot on for him finding the solution for himself.

I agree that he did a reasonable job of trying...
especially posting his work-in-progress. (I give credit to that... some people are too shy to post)

If he had written out his thoughts one line at a time in this format:

IF...
THEN...
ELSE...

he would have avoided the error.




p.s. I think he had solved the problem already...
This is a simple bug, you have given him the clue he needed. it is not that difficult to spot the fault once he thinks it through.
In an anonymous forum, some people just don't have the habit of acknowledging help.

[Charlton]

Besides the advice that Tams gave about writing out your rules in English in advance, I would also suggest that you always include some print statements for use during debugging. An example is shown below:

Print(ELDATETOSTRING(Date ), " ", Time, " LongTrigger: ", LongTrigger, " LongTriggerValue: ", longtriggervalue, " Fastvalue: ", fastvalue, " Slowvalue: ", slowvalue, " A");

The idea is to print out the current values of important variables on each bar. These print out to the Easylanguage output bar, which can be automatically saved to a file upon exit. Each one shows the date and time of the bar plus the variables required. Note that I have also included a reference "A" at the end, because you might want to insert the same print statement at different points in your logic to see how the variables change as the code is processed. By using a different reference for each print statement you can see exactly which part of the code triggers any changes in values.

Normally this will highlight any problems with your logic. Logic/coding problems are IMHO the normal cause of funny results, rather than TS technical issues.

It can be useful also to have an input at the start of the statement, something like:

Inputs:
Print_On("N");

Then you can add a line before the print statement:

If Print_On = "Y" then print(message that needs to be printed);

This allows you to turn the printing on or off during run-time by changing the input.

Charlton

[mrtraderguy]

Mr T G, You can often learn something new by how others approach problem. There was a great thread "plotting globex highs and lows" or something similar. What was good about it is that several methods to do it where presented, some from fairly novice coders. Anyway reading back my post sounds unduly critical that was not my intention, apologies.

No worries, I agree BFish, that's why I just provide options and take nothing personally :-) I've coded in other areas for years, and yet find myself in a new category every day! The only thing we know for sure is that we don't know everything!

Always happy to help where I can and learn everything along the way :-) OK, I'm back to work!

[nab999]

Hi, and many thanks to you all for all your help with this so far.

Blowfish, I put the code, exactly as you posted into ts and ran it on GBPUSD 5 min data.

I attach 3 charts which are showing the problems I am having with this show me. ( Also plotted are the fast and slow moving averages ( the thick ones ) which change to green when both the slow and fast MAs are pointing up. )

I have market the charts with lines and put text at the places that the problems are ocurring, to make things easier to see, as previously suggested by Tams.

Once again, many thanks for all your help.

[Tams]

You did not say WHY this is plotting correctly.
What is your criteria that makes it "correct"?
What should the chart do if the criteria is not met ???

What about the "incorrect" plot?
What is your criteria it did not make that renders it "incorrect"?
What should the chart do if the criteria is not met ???

You might have described your codes in one post or anther,
but don't expect people to look for that section of code...
because that code is "wrong"... it is not producing the effect you want, how can people match that section of code to this picture????
I see lots of lines... do you know which line is which?
Do you know what variables you are evaluating against which?
I don't.


Can you see that your thoughts are not cohesively articulated
and the logic description are incomplete?
Computers are dumb. They can only do what you tell it to do.
If your logic is incomplete, so is the computer's action.


If you are looking a solution... this is the place you really have to make an effort to cover all the bases...
So far I only see you swimming around in shallow water...

[aaa]

ThanX TAMS 2 write 18 lines 2 repeat it again & again

This is what I've leanred from TAMS

2 B clear

First in my head 4 my personnal work

Then 4 the others 2 receive the correct answer

But The road is hard...