[pimind]

Hi,

I'm trying to code this indicator that will let me know the strength of a trend based on 6 moving averages. Basically It plots 2 lines an up and a down. The up trend from 1-6 and down trend -1 to -6. Based on how many ma's are above or below their previous value. It seems to not be plotting correctly if someone could look at it i would greatly appreciate it. I've looked at over and over and can't find what's wrong.

Variables:
	       	aPrice(Close), alength(9),
		   	bprice(Close), blength(15),
			cprice(Close), clength(21),
			dprice(Close), dlength(27),
			eprice(Close), elength(34),
			fprice(Close), flength(40),
			aValue (0),
			bValue (0),
			cValue (0),
			dValue (0),
			eValue (0),
			fValue (0),
	utrend  (0),
	uTrend1	(0)	,
    utrend2 (0),
	utrend3 (0),
	utrend4 (0),
	utrend5 (0),
	utrend6 (0),
    dtrend  (0),
	dTrend1	(0)	,
    dtrend2(0),
	dtrend3 (0),
	dtrend4 (0),
	dtrend5 (0),
	dtrend6 (0);

aValue = jthma(aprice, alength);
bValue = jtHMA(bprice, blength);
cValue = jtHMA(cprice, clength);
dValue = jtHMA(dprice, dlength);
eValue = jtHMA(eprice, elength);
fValue = jtHMA(fprice, flength);


if avalue > avalue[1] then utrend1=1;
if bvalue > bvalue[1] then utrend2=1;
if cvalue > cvalue[1] then utrend3=1;
if dvalue > dvalue[1] then utrend4=1;
if evalue > evalue[1] then utrend5=1;
if fvalue > fvalue[1] then utrend6=1;
if avalue < avalue[1] then dtrend1=1;
if bvalue < bvalue[1] then dtrend2=1;
if cvalue < cvalue[1] then dtrend3=1;
if dvalue < dvalue[1] then dtrend4=1;
if evalue < evalue[1] then dtrend5=1;
if fvalue < fvalue[1] then dtrend6=1;


utrend=utrend1+utrend2+utrend3+utrend4+utrend5+utrend6;
dtrend=dtrend1-dtrend2-dtrend3-dtrend4-dtrend5-dtrend6;







Plot1 (uTrend);
Plot2 (dtrend);

[Tams]

Originally Posted by pimind »

Hi,

I'm trying to code this indicator that will let me know the strength of a trend based on 6 moving averages. Basically It plots 2 lines an up and a down. The up trend from 1-6 and down trend -1 to -6. Based on how many ma's are above or below their previous value. It seems to not be plotting correctly if someone could look at it i would greatly appreciate it. I've looked at over and over and can't find what's wrong.

what program are you using?

[HAL9000]

Hi , as I see it you add values that are 0 or 1.

But in a downtrend, you would have to count it -1

so what about if ... else if ... < ... then -1.

If the values are initialized with 0 as it seems, you don't have to care about the equal case.

Its just my thought, cause I don't code in EL,
but I hope it might help you.

Hal

[pimind]

Sorry, I'M Using tradestation 8.4.

[Tams]

You need to have an "else" value for the variables, otherwise it will keep the previous value, which will always be "1".

give this a try:

input:
aPrice(Close), alength(9),
bprice(Close), blength(15),
cprice(Close), clength(21),
dprice(Close), dlength(27),
eprice(Close), elength(34),
fprice(Close), flength(40);

Variables:
aValue (0),
bValue (0),
cValue (0),
dValue (0),
eValue (0),
fValue (0),
utrend  (0),
uTrend1 (0),
utrend2 (0),
utrend3 (0),
utrend4 (0),
utrend5 (0),
utrend6 (0),
dtrend(0),
dTrend1(0),
dtrend2(0),
dtrend3(0),
dtrend4(0),
dtrend5(0),
dtrend6(0);

aValue = jthma(aprice, alength);
bValue = jtHMA(bprice, blength);
cValue = jtHMA(cprice, clength);
dValue = jtHMA(dprice, dlength);
eValue = jtHMA(eprice, elength);
fValue = jtHMA(fprice, flength);

if avalue > avalue[1] then utrend1=1 else utrend1=0;
if bvalue > bvalue[1] then utrend2=1 else utrend2=0;
if cvalue > cvalue[1] then utrend3=1 else utrend3=0;
if dvalue > dvalue[1] then utrend4=1 else utrend4=0;
if evalue > evalue[1] then utrend5=1 else utrend5=0;
if fvalue > fvalue[1] then utrend6=1 else utrend6=0;

if avalue < avalue[1] then dtrend1=1 else dtrend1=0;
if bvalue < bvalue[1] then dtrend2=1 else dtrend2=0;
if cvalue < cvalue[1] then dtrend3=1 else dtrend3=0;
if dvalue < dvalue[1] then dtrend4=1 else dtrend4=0;
if evalue < evalue[1] then dtrend5=1 else dtrend5=0;
if fvalue < fvalue[1] then dtrend6=1 else dtrend6=0;


utrend=utrend1+utrend2+utrend3+utrend4+utrend5+utrend6;
dtrend=dtrend1-dtrend2-dtrend3-dtrend4-dtrend5-dtrend6;

Plot1 (uTrend);
Plot2 (dtrend);

[pimind]

Here is a pic of the chart with indicator. The indicators are the ma i'm plotting. Thanks Tams I was looking at the code an realized that was the problem. Sometimes you can stare and stare and it just doesn't jump out.

[Tams]

here's how I use the print statement to debug.

http://www.traderslaboratory.com/for...uage-6000.html


First, I added a print statement after the first batch of calculations

aValue = jthma(aprice, alength);
bValue = jtHMA(bprice, blength);
cValue = jtHMA(cprice, clength);
dValue = jtHMA(dprice, dlength);
eValue = jtHMA(eprice, elength);
fValue = jtHMA(fprice, flength);

print(aValue, bValue, cValue, dValue, eValue, fValue );

the red colored Print statement tells me that the variables were properly assigned.



next, I added a print statement after the 2nd batch of calculations:

if avalue > avalue[1] then utrend1=1 else utrend1=0;
if bvalue > bvalue[1] then utrend2=1 else utrend2=0;
if cvalue > cvalue[1] then utrend3=1 else utrend3=0;
if dvalue > dvalue[1] then utrend4=1 else utrend4=0;
if evalue > evalue[1] then utrend5=1 else utrend5=0;
if fvalue > fvalue[1] then utrend6=1 else utrend6=0;

Print(uTrend1, utrend2, utrend3, utrend4, utrend5, utrend6);


The 2nd print statement returns a value of "1" for all variables at all time intervals.

Voila! the culprit is found !

[Tams]

p.s.

I have moved some of your Variables to Inputs.