Welcome to the Traders Laboratory.

Coding Forum Collaborate, receive help, or discuss indicators and other coding-related topics

Reply
Old 05-01-2012, 11:45 AM   #1

Join Date: May 2012
Posts: 3
Ignore this user

Thanks: 0
Thanked 0 Times in 0 Posts

Translate Indicator from Mql4 to EasyLanguage

Hey Community!

I hope I've chosen the right forum for my problem and you are likely to help me...

I'd like to use an indicator from MT4 in tradestation and MultiCharts and tried to translate it from Mql4 to EasyLanguage. But unfortunately it doesn't work that well.

This is the indicator in Mql4:

Code:
//+------------------------------------------------------------------+
//|                                            ATR Trailing Stop.mq4 |
//|                                                                  |
//|                                                                   |
//+------------------------------------------------------------------+
#property  link      ""
//---- indicator settings
#property  indicator_chart_window
#property  indicator_buffers 2
#property  indicator_color1  Blue
#property  indicator_color2  Red

//---- indicator parameters
extern int BackPeriod   = 1000;
extern int ATRPeriod   = 3;
extern double Factor = 3;
extern bool TypicalPrice = false;

//---- indicator buffers
double     ind_buffer1[];
double     ind_buffer2[];

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- drawing settings  
   SetIndexStyle(0,DRAW_LINE,EMPTY,2);
   SetIndexDrawBegin(0,ATRPeriod);
   SetIndexBuffer(0,ind_buffer1);
   SetIndexStyle(1,DRAW_LINE,EMPTY,2);
   SetIndexDrawBegin(1,ATRPeriod);
   SetIndexBuffer(1,ind_buffer2);

   IndicatorDigits(MarketInfo(Symbol(),MODE_DIGITS)+2);
//---- name for DataWindow and indicator subwindow label
   IndicatorShortName("ATR Trailing Stop("+ATRPeriod+" * "+Factor+")");
   SetIndexLabel(0,"Support");
   SetIndexLabel(1,"Resistance");
//---- initialization done
   return(0);
  }
//+------------------------------------------------------------------+
//| Moving Averages Convergence/Divergence                           |
//+------------------------------------------------------------------+
int start()
  {
   int limit;
   int counted_bars=IndicatorCounted();
   double PrevUp, PrevDn;
   double CurrUp, CurrDn;
   double PriceLvl;
   double LvlUp = 0;
   double LvlDn = 1000;
   int Dir = 1;
   int InitDir;
//---- check for possible errors
   if(counted_bars<0) return(-1);
//---- last counted bar will be recounted
   if(counted_bars>0) counted_bars--;
   limit=Bars-counted_bars;
//---- fill in buffervalues
   InitDir = 0;
   for(int i=BackPeriod; i>=0; i--)
   {
      if (TypicalPrice) PriceLvl = (High[i] + Low[i] + Close[i])/3;
      else PriceLvl = Close[i];  

      if(InitDir == 0) {
         CurrUp=Close[i] - (iATR(NULL,0,ATRPeriod,i) * Factor);
         PrevUp=Close[i-1] - (iATR(NULL,0,ATRPeriod,i-1) * Factor);
         CurrDn=Close[i] + (iATR(NULL,0,ATRPeriod,i) * Factor);
         PrevDn=Close[i-1] + (iATR(NULL,0,ATRPeriod,i-1) * Factor);
           
         if (CurrUp > PrevUp) Dir = 1;
         LvlUp = CurrUp;
         if (CurrDn < PrevDn) Dir = -1;
         LvlDn = CurrDn;
         InitDir = 1;
       
      }
      
      CurrUp=PriceLvl - (iATR(NULL,0,ATRPeriod,i) * Factor);
      CurrDn=PriceLvl + (iATR(NULL,0,ATRPeriod,i) * Factor);

      if (Dir == 1) {
         if (CurrUp > LvlUp) {
            ind_buffer1[i] = CurrUp;
            LvlUp = CurrUp;
         }
         else {
            ind_buffer1[i] = LvlUp;
         }
         ind_buffer2[i] = EMPTY_VALUE;
         if (Low[i] < ind_buffer1[i]) {
            Dir = -1;
            LvlDn = 1000;
         }
      }
      
      if (Dir == -1) {
         if (CurrDn < LvlDn) {
            ind_buffer2[i] = CurrDn;
            LvlDn = CurrDn;
         }
         else {
            ind_buffer2[i] = LvlDn;
         }
         ind_buffer1[i] = EMPTY_VALUE;
         if (High[i] > ind_buffer2[i]) {
            Dir = 1;
            LvlUp = 0;
         }
      }
 
   }  
   

//---- done
   return(0);
  }
And this is how I thought I could code in in EasyLanguage:


Code:
Inputs: BackPeriod(1000), ATRPeriod(3), factor(3), typPrice(false);

Variables: countedBars(0), initDir(0), Dir(1), PrevUp(0), PrevDn(0), CurrUp(0), CurrDn(0), PriceLvl(0), LvlUp(0), LvlDn(1000);

//----------------------------------------------------------------------------------------------------------------------------------

if countedBars >= 0 then begin

	//--------------------------
	
	if countedBars > 0 then CountedBars=CountedBars-1;
	
	//--------------------------
	
	Variables: Counter(1);
	
	for Counter = 1 to Counter<=0
	begin
	
		//--------------------------
	
		if typPrice=true then 		
		PriceLvl = (High(Counter)+ Low(Counter) + Close(Counter)) / 3				
		else PriceLvl = Close(Counter);			
		
		//--------------------------
		
		if initDir=0 then begin		
		CurrUp = Close(Counter) -   AvgTrueRange(ATRPeriod)*factor;
		PrevUp = Close(Counter-1) - AvgTrueRange(ATRPeriod)*factor;
		CurrDn = Close(Counter) +   AvgTrueRange(ATRPeriod)*factor;
		PrevDn = Close(Counter-1) + AvgTrueRange(ATRPeriod)*factor;
		
		if CurrUp > PrevUp then Dir=1;
		
		LvlUp=CurrUp;
		
		if CurrDn < PrevDn then Dir=-1;
		
		LvlDn=CurrDn;
		
		initDir=1;
		
		end;
		
		//--------------------------
		
		CurrUp = PriceLvl -  AvgTrueRange(ATRPeriod)*factor;
 		CurrDn = PriceLvl +  AvgTrueRange(ATRPeriod)*factor;

		//--------------------------
		
		Array: ind_buffer1 [](0), ind_buffer2 [](0);
		
		if Dir=1 then begin
			
			if CurrUp > LvlUp then begin
			ind_buffer1[Counter]=CurrUp;
			LvlUp=CurrUp;
			end		
			else begin
			ind_buffer1[Counter]=LvlUp;
			end;
	
			if low(Counter) < ind_buffer1[Counter] then begin
			Dir = -1;
			LvlDn=1000;
			end;
		end;		
		
		//--------------------------

		if Dir=-1 then begin
			
			if CurrDn < LvlDn then begin
			ind_buffer2[Counter]=CurrDn;
			LvlDn=CurrDn;
			end		
			else begin
			ind_buffer2[Counter]=LvlDn;
			end;
	
			if High(Counter) > ind_buffer2[Counter] then begin
			Dir = 1;
			LvlUp = 0;
			end;
		end;
		
		//--------------------------
	//--------------------------
	
	Plot1(ind_buffer1[Counter]);
	Plot2(ind_buffer2[Counter]);
	
	Counter=Counter+1;
	
	//--------------------------
	
	end;
	
end;
I can't try the EasyLanguage code and take a look, if it is, what I want it to be, because compiling finishs with an error description :

Code:
------ Build started: ------
Study: "test01" (Indicator)
Please wait .... 
------ Compiled with error(s): ------
Compile error
errLine 0, errColumn 0, errLineEnd 0, errColumnEnd 0
causal study:  (Function)
I would greatly appreciate any support from you... thanks a lot...

I attached a picture, to show, how the indicator looks in MT4.
Attached Files
File Type: docx Dok1.docx (759.3 KB, 59 views)
FxHulk is offline  
Reply With Quote
Old 05-02-2012, 05:01 AM   #2

Join Date: May 2012
Posts: 3
Ignore this user

Thanks: 0
Thanked 0 Times in 0 Posts

Re: Translate Indicator from Mql4 to EasyLanguage

Ok, I finally made the code run, but it still doesn't draw the line I want to be drawn...
Maybe somebody knows the answer?

The line should be plotted in the chart window, like to see in the picture .... but I don't know how to do it. How to draw a line in the chart and not in a separated window ??

Here is the new code:


Code:
Inputs: BackPeriod(1000), ATRPeriod(3), factor(3), typPrice(false);

Variables: countedBars(0), initDir(0), Dir(1), PrevUp(0), PrevDn(0), CurrUp(0), CurrDn(0), PriceLvl(0), LvlUp(0), LvlDn(1000);

//----------------------------------------------------------------------------------------------------------------------------------

if countedBars >= 0 then begin



	//--------------------------
	
	if countedBars > 0 then CountedBars=CountedBars-1;
	
	//--------------------------
	
	Variables: Counter(BackPeriod);
	
	for Counter = 1 to Counter<=0	
	begin
		
	//if Counter>= 0 then begin
	
		//--------------------------
		
		if typPrice=true then 		
		PriceLvl = (High[Counter] +Low[Counter] + Close[Counter] )/ 3				
		else PriceLvl = Close[Counter] ;			
	
		//--------------------------
		
		if initDir=0 then begin		
		CurrUp = Close[Counter] -   AvgTrueRange(ATRPeriod)*factor;
		PrevUp = Close[Counter-1] - AvgTrueRange(ATRPeriod)*factor;
		CurrDn = Close[Counter] +   AvgTrueRange(ATRPeriod)*factor;
		PrevDn = Close[Counter-1] + AvgTrueRange(ATRPeriod)*factor;
		
		if CurrUp > PrevUp then Dir=1;
		
		LvlUp=CurrUp;
		
		if CurrDn < PrevDn then Dir=-1;
		
		LvlDn=CurrDn;
		
		initDir=1;
		
		end;
		
		//--------------------------
		
		CurrUp = PriceLvl -  AvgTrueRange(ATRPeriod)*factor;
 		CurrDn = PriceLvl +  AvgTrueRange(ATRPeriod)*factor;

		//--------------------------
		
		Array: ind_buffer1 [](0), ind_buffer2 [](0);
		
		if Dir=1 then begin
			
			if CurrUp > LvlUp then begin
			ind_buffer1[Counter]=CurrUp;
			LvlUp=CurrUp;
			end		
			else begin
			ind_buffer1[Counter]=LvlUp;
			end;
	
			if low[Counter] < ind_buffer1[Counter] then begin
			Dir = -1;
			LvlDn=1000;
			end;
		end;		
		
		//--------------------------

		if Dir=-1 then begin
			
			if CurrDn < LvlDn then begin
			ind_buffer2[Counter]=CurrDn;
			LvlDn=CurrDn;
			end		
			else begin
			ind_buffer2[Counter]=LvlDn;
			end;
	
			if High[Counter] > ind_buffer2[Counter] then begin
			Dir = 1;
			LvlUp = 0;
			end;
		end;
		
		//--------------------------
	//--------------------------
	
	Plot1(ind_buffer1[Counter]);
	Plot2(ind_buffer2[Counter]);
	
	Counter=Counter-1;
	
	
	end;
	
	//--------------------------
	
	


end;
FxHulk is offline  
Reply With Quote
Old 05-03-2012, 03:32 AM   #3

Join Date: Jul 2010
Posts: 64
Ignore this user

Thanks: 13
Thanked 16 Times in 14 Posts

Re: Translate Indicator from Mql4 to EasyLanguage

Hi,

tradestation is different from MT4 in calculation. tradestation calculates from left to right and thus the first bar will be 1 and then goes on..

if countedBars >= 0 then begin
if countedBars > 0 then CountedBars=CountedBars-1;

1) In the first bar of calculation the countedBars is set to 0. So in your case, the countedBars will never be > 0.

2) In the for Loop, you have stated that Counter = 1 to to Counter<=0 where Counter is set as Counter(BackPeriod) in the variable.
So I guess it should be like the following:-

Code:
   for X = Counter downto 0	
	begin
                        //your code here
Good Luck
Easytrader_I.
EasyTrader_I is offline  
Reply With Quote
Old 05-03-2012, 05:38 AM   #4

Join Date: May 2012
Posts: 3
Ignore this user

Thanks: 0
Thanked 0 Times in 0 Posts

Re: Translate Indicator from Mql4 to EasyLanguage

Hey EasyTrader_I, thank you for your reply.

Quote:
Originally Posted by EasyTrader_I »
tradestation is different from MT4 in calculation. tradestation calculates from left to right and thus the first bar will be 1 and then goes on..
Does that mean, that the oldest bar on the chart is bar number 1 ? So that I can't catch, for example, the high before the current bar with

Code:
High[1]
? Or do I have to get that value with the phrase

Code:
High of 1 bar ago
FxHulk is offline  
Reply With Quote
Old 05-03-2012, 09:46 PM   #5

Join Date: Jul 2010
Posts: 64
Ignore this user

Thanks: 13
Thanked 16 Times in 14 Posts

Re: Translate Indicator from Mql4 to EasyLanguage

Hi,
"High[1] and High of 1 bar ago" both are same. they both return previous bars High.


Thanks,
Easytrader_I.
EasyTrader_I is offline  
Reply With Quote

Reply

Thread Tools
Display Modes Help Others By Rating This Thread
Help Others By Rating This Thread:

Similar Threads
Thread Thread Starter Forum Replies Last Post
Building a VolumeProfile Indicator with EasyLanguage Andytick Coding Forum 75 03-25-2014 02:40 AM
Mql4 - mql5 Obsidian Coding Forum 0 04-08-2012 02:13 PM
EasyLanguage Indicator -- How Long (in Min) 1500 Tick Bar Took to Complete Frank Coding Forum 3 03-16-2010 10:47 AM
Can Anybody Translate This MetTrade4 Code to EasyLanguage? crtrading Coding Forum 1 11-12-2009 04:48 PM
Adding Sound to Your Indicator (EasyLanguage) Tams Coding Forum 33 05-10-2009 07:58 AM

All times are GMT -4. The time now is 06:59 AM.
Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
CS to VB integration by DeskLancer
2006-2011 Traders Laboratory, All Rights Reserved.