[Blu-Ray]

Hi Tasuki

No, it had no sound, I recorded it through snagit and I don't think it allows for sound.

Cheers

Blu-Ray

[buysell84]

Well, you TS gurus were very helpful to me the other day and so I started to work on a MACD code to change the colors of the MACD when it is greater than the MACDAVG. I have attached what I have so far but it will not verify. It gives me a grammar error stating that it expects "(" at the place where my >= operator is. Can you suggest what I have missed?

[LegacyColorValue = true]; 

{ CW MACD }


inputs: 
	FastLength( 12 ), 
	SlowLength( 26 ), 
	MACDLength( 9 ) ; 

Plot1( MACD( Close, FastLength, SlowLength ), "MACD", Red ) ;
Plot2( XAverage( Plot1, MACDLength ), "MACDAvg", White ) ;
Plot4( 0, "ZeroLine", Yellow) ;

if MACD >= XAverage then SetPlotColor (1,Cyan);

[Blu-Ray]

Originally Posted by buysell84 »

Well, you TS gurus were very helpful to me the other day and so I started to work on a MACD code to change the colors of the MACD when it is greater than the MACDAVG. I have attached what I have so far but it will not verify. It gives me a grammar error stating that it expects "(" at the place where my >= operator is. Can you suggest what I have missed?

[LegacyColorValue = true]; 

{ CW MACD }


inputs: 
	FastLength( 12 ), 
	SlowLength( 26 ), 
	MACDLength( 9 ) ; 

Plot1( MACD( Close, FastLength, SlowLength ), "MACD", Red ) ;
Plot2( XAverage( Plot1, MACDLength ), "MACDAvg", White ) ;
Plot4( 0, "ZeroLine", Yellow) ;

if MACD >= XAverage then SetPlotColor (1,Cyan);

This part is the culprit.

if MACD >= XAverage then SetPlotColor (1,Cyan);

As that sentence is saying if MACD is greater or equals to an xaverage, but it's not stating an xaverage of what.

Here's how it should look:

if MACD >= XAverage( Plot1, MACDLength ) then SetPlotColor (1,Cyan);

Hope this helps

Blu-Ray

[buysell84]

Blu-Ray,

Thanks for your responce. I made the change to the code as you suggested but it still gives the error message when trying to verify that it is expecting "(" at the >= operator. In all the code I looked at to try to do this I don't recall that I have see the operators in (). What is this trying to tell me?

[Blu-Ray]

Originally Posted by buysell84 »

Blu-Ray,

Thanks for your responce. I made the change to the code as you suggested but it still gives the error message when trying to verify that it is expecting "(" at the >= operator. In all the code I looked at to try to do this I don't recall that I have see the operators in (). What is this trying to tell me?

Yes, sorry, my apologies, I didn't read it correctly, again it's a fault as it just says MACD without the bit afterwards:

Here this should work:


if MACD( Close, FastLength, SlowLength ) >= XAverage( Plot1, MACDLength ) then SetPlotColor (1,Cyan);


Personally I would have coded it up like this and it would have saved you a bit of trouble.

[LegacyColorValue = true];

{ CW MACD }


inputs:
FastLength( 12 ),
SlowLength( 26 ),
MACDLength( 9 ) ;

Vars:
MyMACD(0),MACDAvg(0);

MyMACD = MACD( Close, FastLength, SlowLength );
MACDAvg = XAverage(MyMACD, MACDLength );

Plot1( MyMACD,"MACD", Red ) ;
Plot2( MACDAvg,"MACDAvg", White ) ;
Plot4( 0, "ZeroLine", Yellow) ;

if MyMACD >= MACDAvg then SetPlotColor (1,Cyan);


Hope this helps

Blu-Ray

[buysell84]

Blue-Ray,

That was fab. I used your code because it is much more elegant. I have a lot to learn.

Have a look at the file I attached. You can see where the MACD crossed the Avg line but doesn't change color immediately. I am guessing this has to do with the previous bar. Is there coding I can use to have the plot change so that it is spot on the cross over? I appreciate this very much and will be willing to post this indicator is anyone is interested.

[Blu-Ray]

You are not going to get it to change immediately as the MACDAvg could be sitting it between the values of the MACD of now & previous bar.


Cheers


Blu-Ray